Skip to content

Conversation

barjin
Copy link
Contributor

@barjin barjin commented Feb 7, 2025

Bumps the available heap size for the doc-building Docusaurus process. We already do this e.g. in Crawlee JS.

@barjin barjin added the adhoc Ad-hoc unplanned task added during the sprint. label Feb 7, 2025
@barjin barjin self-assigned this Feb 7, 2025
@github-actions github-actions bot added this to the 107th sprint - Tooling team milestone Feb 7, 2025
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Feb 7, 2025
Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should move to docusaurus 3.7 with rspack, it should solve this too

@barjin
Copy link
Contributor Author

barjin commented Feb 7, 2025

Good catch! The max-old-space-size flag apparently doesn't work at all. Weirdly, I didn't manage to reproduce this locally. Let's see how the latest Docusaurus performs with experimental_faster


.tagline span {
color: var(--ifm-color-primary);
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new rspack bundler (or adjacent tooling) seems to wrongly resolve !important CSS rules (the tagline had blue words instead of transparent). Removing this rule seems to fix the issue (and not break anything else.)

@B4nan
Copy link
Member

B4nan commented Feb 7, 2025

Its already set up on the main docs repo, we need to keep the swc loader disabled since that doesn't work well (or should I say at all) with styled components.

https://github.com/apify/apify-docs/blob/master/docusaurus.config.js#L22

Although it might be fine in this repo, the place where we use it is in the landing pages like http://docs.apify.com/api

@barjin
Copy link
Contributor Author

barjin commented Feb 7, 2025

Huh, it seems that rspack doesn't unblock the stalling CI builds either 🙃 I'll try reproducing it locally a bit more and see what I can come up with.

@barjin
Copy link
Contributor Author

barjin commented Feb 10, 2025

Closing as solved by apify/apify-docs#1452

@barjin barjin closed this Feb 10, 2025
@barjin barjin deleted the fix/unblock-docs-build branch February 10, 2025 13:17
@B4nan
Copy link
Member

B4nan commented Feb 10, 2025

I would still merge this one with the docusaurus update, or is there any reason not to?

@barjin
Copy link
Contributor Author

barjin commented Feb 10, 2025

Oh yeah, that makes sense. Let me regenerate the lockfile anew (there seem to be quite a lot of unrelated changes as a result of the debugging) and we can switch to 3.7.0.

@barjin barjin reopened this Feb 10, 2025
@barjin barjin merged commit 42ae0b8 into master Feb 10, 2025
45 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants